Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

primevue@4.0.0-rc.1 incorrect background colors #5894

Closed
julichan opened this issue Jun 14, 2024 · 5 comments
Closed

primevue@4.0.0-rc.1 incorrect background colors #5894

julichan opened this issue Jun 14, 2024 · 5 comments
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@julichan
Copy link

julichan commented Jun 14, 2024

Describe the bug

Hello,

Colors breaks from primevue@4.0.0-rc.1 where they worked well on beta4
Fieldset and Card are perfect white in light mode and transparent in darkmode. --p-content-background is defined to those colors.

Reproducer

https://stackblitz.com/edit/primevue-create-vue-issue-template

PrimeVue version

4.0.0-rc.1

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

Edge, chrome

Steps to reproduce the behavior

I use the following configuration from documentation:
// Initialize Prime vue
app.use(PrimeVue, {
theme: {
preset: Aura,
options: {
prefix: 'p',
darkModeSelector: 'system', // setting this to a class sets the background to pure white (p-surface-0 ffffff)
cssLayer: true // Changing this value did not seem to change a single thing.
}
},
ripple: true
});

I don't have any customization of the style variables or whatsoever

Expected behavior

The background colors or the components should have dark colors in dark mode and light colors (I'm guessing not perfect white) in light mode.

@julichan julichan added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jun 14, 2024
@julichan julichan changed the title Component Name: Issue Title primevue@4.0.0-rc.1 incorrect background colors Jun 14, 2024
@luke-z
Copy link

luke-z commented Jun 14, 2024

Seems to be the reason for #5890

@julichan
Copy link
Author

I did not use any popup thought. I only have fieldsets and buttons at the moment

@JediPixels
Copy link

The entire Dark theme backgrounds are transparent now. I upgraded from beta 4 to rc1 and it changed. If you check out any component on the PrimeVue site like the DatePicker https://primevue.org/datepicker/ you can see the effects.

Thanks.

@julichan
Copy link
Author

julichan commented Jun 14, 2024

It seems the commit at fault is a054a92
All it does is transforming the dark theme background to transparent. can this be reverted ?

I managed to temporarily revert the problem by copying a part of the definePreset in the documentation which was not updated alongside the commit.

Thanks,

@mertsincan
Copy link
Member

Fixed in de2560a

@mertsincan mertsincan added this to the 4.0.0-rc.2 milestone Jun 16, 2024
@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

4 participants