Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu: Using the popup mode, the menu has a transparent background in dark mode. #5890

Closed
luke-z opened this issue Jun 14, 2024 · 3 comments
Closed
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@luke-z
Copy link

luke-z commented Jun 14, 2024

Describe the bug

The background of the Menu component, when using it in popup mode, is transparent when using a dark mode theme.

image

It can be observed on the primevue website itself, thus I have not created a reproducer.
It works in light mode as expected.

Reproducer

https://primevue.org/menu/#popup

PrimeVue version

4.0.0-rc.1

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

Brave

Steps to reproduce the behavior

  1. Go to the primevue website linked in the reproducer
  2. Set the color mode to dark
  3. Click on the popup button to display the menu

Expected behavior

Menu should have a background color

@luke-z luke-z added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jun 14, 2024
@JediPixels
Copy link

The entire Dark theme backgrounds are transparent now. I upgraded from beta 4 to rc1 and it changed. If you check out any component on the PrimeVue site like the DatePicker https://primevue.org/datepicker/ you can see the effects.

You can even check out the Card component in dark mode and you can see the background is transparent:
https://primevue.org/card/

Thanks.

@mertsincan
Copy link
Member

Fixed in de2560a

@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jun 16, 2024
@mertsincan mertsincan added this to the 4.0.0-rc.2 milestone Jun 16, 2024
@JediPixels
Copy link

I updated to rc.2 and it's working again... thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants