Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard support problem for AutoComplete #723

Closed
nimruth opened this issue Nov 30, 2020 · 2 comments
Closed

Keyboard support problem for AutoComplete #723

nimruth opened this issue Nov 30, 2020 · 2 comments
Assignees
@cagataycivici
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.1.0

Comments

@nimruth
Copy link

nimruth commented Nov 30, 2020

hitting 'ArrowDown' to highlight the first element is not working.

using DomHandler.addClass(this.overlay.firstChild.firstElementChild, 'p-highlight'); instead of DomHandler.addClass(this.overlay.firstChild.firstChild, 'p-highlight'); will fix it
@dheimoz
Copy link

dheimoz commented Dec 1, 2020

This feature could be handy for accessibility purposes. Hope @cagataycivici could consider this for the next milestone.

@cagataycivici cagataycivici self-assigned this Dec 9, 2020
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Dec 9, 2020
@cagataycivici cagataycivici changed the title Keyboard support for AutoComplete Keyboard support problem for AutoComplete Dec 9, 2020
@cagataycivici cagataycivici added this to the 3.1.0 milestone Dec 9, 2020
cagataycivici added a commit that referenced this issue Dec 9, 2020
@cagataycivici
Merge pull request #731 from nimruth/master
c30e0cd 
Fixed #723: Keyboard support for AutoComplete
@cagataycivici
Copy link
Member

Resolved now, thank you.

@cagataycivici cagataycivici mentioned this issue Dec 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.1.0
Development

No branches or pull requests
3 participants
@dheimoz @cagataycivici @nimruth