Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primevue 2 dismissableMask=true not working when clicking outside the modal #741

Closed
kelvinabella opened this issue Dec 7, 2020 · 11 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working vue2
Milestone

Comments

@kelvinabella
Copy link

Code can be seen here https://codesandbox.io/s/mystifying-shaw-080f3?file=/src/App.vue

nestorrente added a commit to nestorrente/primevue that referenced this issue Dec 8, 2020
@cagataycivici cagataycivici self-assigned this Dec 9, 2020
@cagataycivici cagataycivici added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working vue2 labels Dec 9, 2020
@cagataycivici cagataycivici added this to the 2.3.0 milestone Dec 9, 2020
@linh0801
Copy link

the issue has not been solved in V2.3.0. At Dialog.vue , line 131 "this.mask === event.tagert" , the mask is undefined @cagataycivici

@linh0801
Copy link

How can I to update this version by npm , I can't found the package of latest V2.x at the npm repository @cagataycivici @tugcekucukoglu

@nebulade
Copy link

As far as I can tell this is also broken in version 3.1.1

@cagataycivici
Copy link
Member

Works for me on 3.2.0-rc.1, will check for 2.x.

@nebulade
Copy link

I have tried 3.2.0-rc.1 now and it still does not work. However by accident I found that it works fine, but only if also closable is set to true. I didn't specify this, since I didn't want to see the close button in the top-right.
Not sure why both properties are dependent on each other, but if that is intentional, maybe the docs could mention this.

@MiC11w
Copy link

MiC11w commented Apr 8, 2021

still broken in version 3.3.5

@Nabeelaron
Copy link

still broken in verison 3.5.1 as well. Please look into this.
Thanks.

@tugcekucukoglu
Copy link
Member

For 3.5.1, cannot replicate it. https://codesandbox.io/s/cool-bash-p4w3g

@SabinoWS
Copy link

Hello!

It will only work if you use also :modal="true"
Because modal false will block the background of modal, so you cant click do dismiss with :dismissableMask="true"

Working example:

<Dialog
    v-bind="$attrs"
    :visible="visible"
    :draggable="draggable"
    :modal="true"
    :dismissableMask="true"
  >
    Test content
  </Dialog>

@cagataycivici
Copy link
Member

Works for 3.5.1;

https://codesandbox.io/s/cool-bash-p4w3g

Please create a new ticket with a code sandbox template demonstrating the issue.

@richardshergold
Copy link

Something to note: this doesn't work if you have :closable="false" specified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working vue2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants