Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScrollTop props have wrong type definitions #963

Closed
ananni13 opened this issue Feb 10, 2021 · 1 comment
Closed

ScrollTop props have wrong type definitions #963

ananni13 opened this issue Feb 10, 2021 · 1 comment
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@ananni13
Copy link

interface ScrollToProps {
target?: string;
threshold?: number;
icon?: boolean;
behavior?: boolean;
}
declare class ScrollTo {
$props: ScrollToProps;
}
export default ScrollTo;

icon and behavior should be of type string. (Docs)

Also, shouldn't the class be named ScrollTop instead of ScrollTo?

@cagataycivici cagataycivici self-assigned this Feb 17, 2021
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Feb 17, 2021
@cagataycivici cagataycivici added this to the 3.3.0-rc.1 milestone Feb 17, 2021
@cagataycivici
Copy link
Member

Got it thanks.

cagataycivici added a commit that referenced this issue Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants