fix: DataTable: Selection and focus loss when no custom ContextMenu is defined #3925
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes
When a
DataTable
does not use a customContextMenu
, it still clears the user's selection.A demonstration of the bug:
data-table-bug.webm
And with this proposed fix:
data-table-fix.webm
All custom events will work as before, but users might have to manually call the selection clear and focus methods from their own
row-contextmenu
listeners, which is less restrictive, but maybe a BC break.closes #3927