Improve datatable performance #4008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
+1 pls merge |
|
Thank you for these hints I applied the same fixes to PrimeReact: primefaces/primereact#4769 |
tugcekucukoglu
requested changes
Aug 17, 2023
tugcekucukoglu
added
the
Resolution: Needs Revision
tugcekucukoglu
approved these changes
Aug 18, 2023
tugcekucukoglu
removed
the
Resolution: Needs Revision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps fix #4007
This PR does 2 main things to help improve filtering and sorting performance for DataTables:
sortSinglefunction, performing calls toresolveFieldData(data1, this.d_sortField)only once for each item in the dataset, and using aMapfor later lookups.filterfunction, only run filters whosevalueis notnull.