Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toast: add the "remove" method to close a specific toast message #4101

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Toast: add the "remove" method to close a specific toast message #4101

merged 2 commits into from
Oct 5, 2023

Conversation

clemvnt
Copy link
Contributor

@clemvnt clemvnt commented Jul 3, 2023

Fixes #1763

Hello!

First of all, thank you for your work.

I have a need where in a toast, there is a button that must execute a process and close the toast on which the user has clicked. I can't use the group mechanism because :

  • By using the removeGroup method, all the toasts in the group close.
  • By using a different group for each toast, the toasts are no longer stacked.

This PR is based on #1395. On the original PR, it says that you were going to implement a simular solution but the discussion dates back to 2021. There's been no news since, so I'll take my shot with this PR. 😀

Let me know if I've missed anything or if you prefer another implementation.

@vercel
Copy link

vercel bot commented Jul 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primevue ⬜️ Ignored (Inspect) Jul 6, 2023 3:01pm

@mertsincan
Copy link
Member

Hi @clemvnt,

Please see my comment;
primefaces/primeng#13599 (comment)

Could you write your feedback on the thread above? Thanks a lot!
Best Regards,

@mertsincan mertsincan added the Status: Discussion Issue or pull request needs to be discussed by Core Team label Sep 5, 2023
@mertsincan mertsincan added this to the 3.x milestone Sep 5, 2023
@mertsincan mertsincan removed this from the 3.x milestone Oct 5, 2023
@mertsincan mertsincan removed the Status: Discussion Issue or pull request needs to be discussed by Core Team label Oct 5, 2023
@mertsincan mertsincan merged commit cee9688 into primefaces:master Oct 5, 2023
2 of 4 checks passed
@mertsincan
Copy link
Member

Thanks a lot for your contribution!

Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to close a specific toast message
2 participants