Fix ambigious clearing behaviour on SelectButton #4107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Hey – just wondering if there's anything I can do to help move this PR along? |
SoyDiego
approved these changes
Sep 10, 2023
jnoordsij
approved these changes
Sep 11, 2023
|
Thanks a lot for your contribution! Best Regards, |
|
@Coretteket and @mertsincan Can you have a look at #4731 I think this attribute has an unwanted sideeffect on the |
By the looks of things, the old |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3610, the meaning of the
unselectableproperty on SelectButton was reversed from "able to unselect" to "unable to unselect". Because the documentation was not updated accordingly, the property currently behaves exactly opposite to how it's described.In #3708 and #3973, there was significant disagreement as to what the property should mean. I would agree with those arguing that the textbook meaning of "unselectable" would be that you are able to unselect. However, the name clearly causes some confusion.
In this PR, I've therefore deprecated the
unselectableproperty in favour of theallowEmptyproperty, to avoid further breaking changes. This naming is much less ambigious, and matches the one already found on InputNumber. I've also updated the documentation forunselectableto match current behaviour.Please let me know if I've missed anything, or if further clarification is needed!
Fixes #3973.