Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resize event to splitter #4526

Merged
merged 4 commits into from
Oct 6, 2023
Merged

Add resize event to splitter #4526

merged 4 commits into from
Oct 6, 2023

Conversation

Ice-Hazymoon
Copy link
Contributor

Add resizing event to splitter component

<Splitter style="height: 300px" class="mb-5" @resizing="console.log">
    <SplitterPanel class="flex align-items-center justify-content-center"> Panel 1 </SplitterPanel>
    <SplitterPanel class="flex align-items-center justify-content-center"> Panel 2 </SplitterPanel>
</Splitter>

@vercel
Copy link

vercel bot commented Sep 30, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primevue ⬜️ Ignored (Inspect) Visit Preview Oct 6, 2023 1:34am

@mertsincan
Copy link
Member

Thanks a lot for your contribution! I think its name can be 'resize' instead of 'resizing'. Also, could you please create a Github issue and link it to this PR? Then, I'll merge it asap.

@mertsincan mertsincan added Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. Resolution: Needs Issue An issue needs to be created for the pull request labels Oct 5, 2023
@Ice-Hazymoon Ice-Hazymoon mentioned this pull request Oct 5, 2023
Closed
@Ice-Hazymoon
Copy link
Contributor Author

Thanks a lot for your contribution! I think its name can be 'resize' instead of 'resizing'. Also, could you please create a Github issue and link it to this PR? Then, I'll merge it asap.

#4561

@mertsincan
Copy link
Member

Thanks a lot! Also, please see https://github.com/primefaces/primevue/pull/4526/files#r1347812333

@Ice-Hazymoon
Copy link
Contributor Author

Thanks a lot! Also, please see https://github.com/primefaces/primevue/pull/4526/files#r1347812333

Sorry, I fixed it.

@mertsincan mertsincan merged commit 82cd43d into primefaces:master Oct 6, 2023
2 of 3 checks passed
@mertsincan
Copy link
Member

Thanks a lot for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mertsincan mertsincan mertsincan left review comments

Assignees
No one assigned
Labels
Resolution: Needs Issue An issue needs to be created for the pull request Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ice-Hazymoon @mertsincan