Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4653 - Edit dialog tailwind class #4654

Merged
merged 1 commit into from Nov 13, 2023

Conversation

naynyeinchan
Copy link
Contributor

The issue of max height not working was resolved by changing the class from "max-h-90" to "max-h-[90%]" with arbitrary percentage values.

###Defect Fixes
Issue : #4653

The issue of max height not working was resolved by changing the class from "max-h-90" to "max-h-[90%]" with arbitrary percentage values.
@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primevue ⬜️ Ignored (Inspect) Visit Preview Oct 19, 2023 8:43am

@naynyeinchan naynyeinchan changed the title Fix #4650 - Edit dialog tailwind class Fix #4653 - Edit dialog tailwind class Oct 19, 2023
Copy link
Member

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update the Dialog docs that have this incorrectly too.

@tugcekucukoglu tugcekucukoglu merged commit fbe4da7 into primefaces:master Nov 13, 2023
2 of 4 checks passed
@naynyeinchan
Copy link
Contributor Author

I have updated the documents and opened a new pull request #4825

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants