Fix ConfirmPopup placement on stopped events #5930
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation only sets the ConfirmPopup position in bindOutsideClickListener, when a click is registered on the root window that isn't on the popup itself. This is an issue, as it does not work if the click event that caused the popup to appear does not propagate up to the root window. Instead, this change always positions the window when it appears. This is already what the Popover component does, which does not exhibits the same bug. Fix primefaces#5929
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation only sets the ConfirmPopup position in bindOutsideClickListener, when a click is registered on the root window that isn't on the popup itself.
This is an issue, as it does not work if the click event that caused the popup to appear does not propagate up to the root window.
Instead, this change always positions the window when it appears. This is already what the Popover component does, which does not exhibits the same bug.
Defect Fixes
Fix #5929