Fix all clippy and rustc warnings (beta toolchain version 0.1.77)

The `suspicious_open_options` lint [0] warns that the truncation
behaviour should be made explicit when creating new files. We also set
`create_new(true)`, which ensures that a new file will *always* be
created so we should simply drop `create(true)` since it has no effect
anyway: "If `.create_new(true)` is set, `.create()` and `.truncate()`
are ignored." [1]

The `unconditional_recursion` lint [2] also emits a warning but that's a
false positive and should already be fixed in nightly (see [3] for a
very similar case and [4] for the PR that should fix it).
In our case we're comparing tuples with just two fields of the `Package`
structure so it isn't recursive.

[0]: https://rust-lang.github.io/rust-clippy/master/index.html#/suspicious_open_options
[1]: https://docs.rs/tokio/1.34.0/tokio/fs/struct.OpenOptions.html#method.create_new
[2]: https://rust-lang.github.io/rust-clippy/master/index.html#/unconditional_recursion
[3]: rust-lang/rust-clippy#12133
[4]: rust-lang/rust-clippy#12137

Signed-off-by: Michael Weiss <michael.weiss@eviden.com>

src/endpoint/scheduler.rs

@@ -512,7 +512,6 @@ impl<'a> LogReceiver<'a> {
                     self.job.uuid()
                 ));
                 tokio::fs::OpenOptions::new()
-                    .create(true)
                     .create_new(true)
                     .write(true)
                     .open(&path)

src/package/package.rs

@@ -221,6 +221,8 @@ impl<'a> std::fmt::Debug for DebugPackage<'a> {
 }
 
 impl PartialEq for Package {
+    // Ignore the following lint as it results in a false positive with clippy 0.1.77:
+    #[allow(clippy::unconditional_recursion)]
     fn eq(&self, other: &Package) -> bool {
         (self.name(), self.version()).eq(&(other.name(), other.version()))
     }

src/source/mod.rs

@@ -135,7 +135,6 @@ impl SourceEntry {
 
         trace!("Creating file now: {}", p.display());
         tokio::fs::OpenOptions::new()
-            .create(true)
             .create_new(true)
             .write(true)
             .open(&p)