Skip to content

Commit

Permalink
isync: Disable the XOAUTH2 support by default as it caused regressions
Browse files Browse the repository at this point in the history
The XOAUTH2 support was recently added in 47eda8e but apparently it
causes regressions when using other SASL methods.
An example error message:
```
IMAP command 'AUTHENTICATE XOAUTH2 SOMEHASH=' returned an error: NO [AUTHENTICATIONFAILED] Invalid credentials (Failure)
```

The cause seems to be that overriding `SASL_PATH` drops all available
SASL mechanisms from `cyrus_sasl`, so only `XOAUTH2` (and `EXTERNAL`)
will be left. See [0] and the following comments for more details.

We'd need to set `SASL_PATH` to a combination/merge of
`${cyrus_sasl}/lib/sasl2` and `${cyrus-sasl-xoauth2}/lib/sasl2`.
Anyway, it seems best to disable the XOAUTH2 support by default due to
the two other concerns mentioned in the comment.

[0]: NixOS#235148 (comment)

Reported-by: Dominik Schrempf <dominik.schrempf@gmail.com>
  • Loading branch information
primeos committed Jun 4, 2023
1 parent 8d08c93 commit fe02c5e
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion pkgs/tools/networking/isync/default.nix
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
{ lib, stdenv, fetchurl, pkg-config, perl
, openssl, db, cyrus_sasl, zlib
, Security
, withCyrusSaslXoauth2 ? true, cyrus-sasl-xoauth2, makeWrapper
# Disabled by default as XOAUTH2 is an "OBSOLETE" SASL mechanism and this relies
# on a package that isn't really maintained anymore:
, withCyrusSaslXoauth2 ? false, cyrus-sasl-xoauth2, makeWrapper
}:

stdenv.mkDerivation rec {
Expand Down

0 comments on commit fe02c5e

Please sign in to comment.