Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port behaviors from Primer React #1

Merged
merged 6 commits into from
Dec 2, 2021
Merged

Port behaviors from Primer React #1

merged 6 commits into from
Dec 2, 2021

Conversation

dgreif
Copy link
Member

@dgreif dgreif commented Dec 2, 2021

The files found in https://github.com/primer/react/tree/main/src/behaviors were written as "vanilla" js behaviors with the intention that they may some day be extracted and shared with other projects. We are now at a point where we would like to use some of these behaviors elsewhere, and this repo is where the shared behaviors will live. This PR sets up the new project and ports the behaviors directly from PRC (largely unaltered, minus some lint related tweaks).

Supports https://github.com/github/primer/issues/483

TODO after this PR:

@dgreif dgreif changed the title Port from prc Port behaviors from Primer React Dec 2, 2021
@dgreif dgreif marked this pull request as ready for review December 2, 2021 21:16
@dgreif dgreif requested a review from colebemis December 2, 2021 21:17
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Co-authored-by: Cole Bemis <colebemis@github.com>
@dgreif dgreif merged commit 695858c into main Dec 2, 2021
@dgreif dgreif deleted the port-from-prc branch December 2, 2021 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants