Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 [BUG] - Testimonial: insufficient contrast for default quote symbol in dark mode #521

Closed
sergioalvz opened this issue Jan 15, 2024 · 1 comment 路 Fixed by #532
Closed
Assignees
Labels
brand bug Something isn't working

Comments

@sergioalvz
Copy link

Describe the bug

In the Testimonial component, when the quoteMarkColor is set to default, it utilizes a black quote symbol. While this works well in the light theme, it poses a legibility issue in dark mode due to the lack of sufficient contrast.

Screenshot of a testimonial component in dark mode

Reproduction steps

https://codepen.io/sergioalvz/pen/ExGrxXb

Expected behavior

Primer Brand provides high-contrast color values for the default quote mark color, ensuring visibility and readability in both light and dark themes.

Screenshots

No response

Browsers

Firefox, Chrome, Safari

OS

Mac

@danielguillan
Copy link
Contributor

Thanks for submitting this bug report, @sergioalvz. There's a fix coming in #532 and will ship in the upcoming release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brand bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants