Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testimonial component color modes support #532

Merged
merged 4 commits into from
Feb 7, 2024

Conversation

danielguillan
Copy link
Contributor

Summary

Adds missing color mode support to Testimonial component. Fixes #521

Before After
The testimonial component without color modes support The testimonial component with color modes support

@danielguillan danielguillan added bug Something isn't working update snapshots labels Feb 6, 2024
Copy link

changeset-bot bot commented Feb 6, 2024

🦋 Changeset detected

Latest commit: cf2d1d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@primer/react-brand Patch
@primer/brand-primitives Patch
@primer/brand-e2e Patch
@primer/brand-fonts Patch
@primer/brand-config Patch
@primer/brand-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 6, 2024

🟢 No design token changes found

Copy link
Contributor

github-actions bot commented Feb 6, 2024

⚠️ Visual differences found

Our visual comparison tests found UI differences.

Please review the differences by using the test artifacts to ensure that the changes were intentional.

Artifacts can be downloaded and reviewed locally.

Download links are available at the bottom of the workflow summary screen.

Example:

artifacts section of workflow run

If the changes are expected, please run npm run test:visual:update-snapshots to replace the previous fixtures.

Review visual differences

Copy link
Collaborator

@rezrah rezrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Could you please add a changeset before merging @danielguillan, otherwise good to go.

@danielguillan danielguillan merged commit 17df500 into main Feb 7, 2024
16 of 17 checks passed
@danielguillan danielguillan deleted the danielguillan/fix-testimonial-color-modes branch February 7, 2024 18:30
@primer-css primer-css mentioned this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working update snapshots
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - Testimonial: insufficient contrast for default quote symbol in dark mode
2 participants