Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 [BUG] - className is missing on <Hero.Description> #528

Closed
simurai opened this issue Feb 1, 2024 · 0 comments 路 Fixed by #529
Closed

馃悰 [BUG] - className is missing on <Hero.Description> #528

simurai opened this issue Feb 1, 2024 · 0 comments 路 Fixed by #529
Labels
bug Something isn't working

Comments

@simurai
Copy link
Contributor

simurai commented Feb 1, 2024

Describe the bug

It seems not possible to use a className on the <Hero.Description>.

Reproduction steps

  1. Go to https://primer.style/brand/components/Hero/react.
  2. Paste following example:
    <Hero className="HeroClass">
      <Hero.Heading className="HeroHeadingClass">Heading</Hero.Heading>
      <Hero.Description className="HeroDescriptionClass">Description</Hero.Description>
    </Hero>
  3. Inspect class names with DevTools.
  4. Notice how the HeroDescriptionClass is missing on <Hero.Description>.

Expected behavior

HeroDescriptionClass should be applied on <Hero.Description>.

Screenshots

Arrow point to the HTML where the classname should appear

Browsers

Chrome

OS

Mac

@simurai simurai added the bug Something isn't working label Feb 1, 2024
alexbuiltit added a commit to alexbuiltit/primer-brand that referenced this issue Feb 1, 2024
rezrah added a commit that referenced this issue Feb 5, 2024
* fix: spread props on HeroDescription
Refs: #528

* fix: Change approach to destructure className

* chore: remove outdated changeset

* Update .changeset/dry-news-dress.md

Co-authored-by: Rez <13340707+rezrah@users.noreply.github.com>

---------

Co-authored-by: Rez <13340707+rezrah@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant