Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overflow-x and overflow-y to utilities #587

Closed
emilybrick opened this issue Oct 22, 2018 · 2 comments
Closed

Add overflow-x and overflow-y to utilities #587

emilybrick opened this issue Oct 22, 2018 · 2 comments

Comments

@emilybrick
Copy link
Contributor

This is a follow up for this PR . .overflow-auto was put on the team nav to solve for scrolling the navigation on smaller screens. However, doing so resulted in an unnecessary vertical scroll bar as well.

Including overflow-x and y utilities in Primer would help solve for instances where an overflow on only one (x or y) axis is required.

In the PR, as a workaround, we've included custom styles to account for overflow-x: auto and overflow-y: hidden. Once we add these utilities to the library we should go back and clean up the above PR (e.g. remove the custom styling).

@shawnbot shawnbot added this to v10.10.0 Release in 📦 Primer CSS release tracking Oct 22, 2018
@shawnbot shawnbot moved this from v10.10.0 Release to Release backlog in 📦 Primer CSS release tracking Nov 15, 2018
@shawnbot
Copy link
Contributor

Another note: we didn't include auto in our first pass at per-axis utilities. Let's add those and wrap this up.

@shawnbot shawnbot self-assigned this May 13, 2019
@shawnbot
Copy link
Contributor

We do, in fact, have overflow: auto utilities:

.overflow-auto { overflow: auto !important; }
.overflow-x-auto { overflow-x: auto !important; }
.overflow-y-auto { overflow-y: auto !important; }

📦 Primer CSS release tracking automation moved this from Release backlog to 💜 Done May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants