Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade node-sass to resolve tar vulnerability #796

Closed
shawnbot opened this issue May 14, 2019 · 3 comments
Closed

Upgrade node-sass to resolve tar vulnerability #796

shawnbot opened this issue May 14, 2019 · 3 comments

Comments

@shawnbot
Copy link
Contributor

See sass/node-sass#2625 (comment) for why this is tricky to fix.

TL;DR: Deep down in our dependency tree (node-sassnode-gypnode-tar) lives an old version of tar that's susceptible to an arbitrary file overwrite vulnerability. We can't resolve it by just installing a newer version of tar; we're stuck waiting on a new node-sass release.

@shawnbot
Copy link
Contributor Author

FYI, according to sass/node-sass#2625 (comment), running npm audit --fix and committing package-lock.json should resolve this now. ❤️

@simurai
Copy link
Contributor

simurai commented Sep 8, 2020

@shawnbot still thinking about Primer CSS.. 😄 ❤️

Gave this a try in #1161

@shawnbot
Copy link
Contributor Author

shawnbot commented Sep 8, 2020

@simurai Just going through my backlog of issues and trying to clean things up. I hope you're well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Publishing workflow
  
Shipped 🚢
Development

No branches or pull requests

3 participants