Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback for new styleguide site #816

Closed
gladwearefriends opened this issue Jun 10, 2019 · 1 comment
Closed

Feedback for new styleguide site #816

gladwearefriends opened this issue Jun 10, 2019 · 1 comment

Comments

@gladwearefriends
Copy link
Contributor

Hey friends

I started using the new styleguide for primer css!

Wanted to drop my two cents on two things that have caught my eye:

Suggestion 1: bring back the bullet point outline list of links at the top of each guide

For example, on the old Colors guide
image

Glancing at this list lets me confirm if I am on the correct page or not (i.e. some topics as our border radius utility are intuitive to me as to which page they live on - border? box?). The list also lets me jump to relevant section on the page quicker instead of scrolling.

Perhaps it was taken out for good reason but I just wanted to share my two cents!

Suggestion 2: bump up the contrast of the search input

image

When i looked for it the first time I glanced right over it and thought there wasnt an input. Adjusting the word Search to be lighter would be super helpful!

Thank you for listening!! and thank you for all of your beautiful work to help us all work better and faster!

@primer/design-systems

@simurai
Copy link
Contributor

simurai commented Jun 11, 2019

Suggestion 1

Not sure if primer/blueprints has support for.. I think they are called "toc" (table of contents)? I agree, it would be handy to get an overview or want to jump to a specific section. 👍

Suggestion 2

👍 Yeah, good point.

I'll split this issue into two and move it to primer/blueprints so it can be addressed separately. @gladwearefriends Thanks for the feedback. ❤️ 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants