-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BannerAnimations #11
BannerAnimations #11
Conversation
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Josh <jhuashao@github.com>
If/when this builds, it should be available to preview at https://primer-design-banner.now.sh 🤞 |
TIL how to use dynamic, client-side-only imports in Next.js! 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is rad, let's ship it!
import dynamic from 'next/dynamic' | ||
import animation from './BannerAnimation.json' | ||
|
||
const ReactBodymovin = dynamic(() => import('react-bodymovin'), { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future reference: this was necessary because react-bodymovin
doesn't work server-side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3!
Banner Animation created as a hero for Primer's Design Guidelines homepage website.
Incorporates:
Full Process Documentation located at this Issue: