New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a11y docs #111
Add a11y docs #111
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/design/7eqw2r5ej |
@ichelsea let me know when you want some feedback 😸 |
@yaili have at the two pages that are ready for feedback! (Accessibility at GitHub and Designer Toolkit) |
@yaili These pages are ready for review: |
I'll other my other suggestions in comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some re-org suggestions.. otherwise ✨ .
For an informative list on real-life disability situations, check [An Alphabet of Accessibility Issues](https://the-pastry-box-project.net/anne-gibson/2014-july-31), published in The Pastry Box Project. | ||
|
||
Microsoft has created a downloadable PDF that looks into the area of inclusive design from a people perspective, with several informative examples. Navigate to the ‘Inclusive 101’ toolkit on the main page of [Microsoft’s Inclusive Design website](https://www.microsoft.com/design/inclusive/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This area could be condensed and listed as "Additional resources".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left these mentions in this section because they're both related to who we should consider while designing. Is it okay to keep them in this section and then do something like:
Additional resources
- An Alphabet of Accessibility Issues, published by The Pastry Box Project, has an informative list on real-life disability situations.
- Microsoft has created a downloadable PDF that looks into the area of inclusive design from a people perspective, with several informative examples. Navigate to the ‘Inclusive 101’ toolkit on the main page of Microsoft’s Inclusive Design website.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok for me, @ashygee ?
## Internal resources | ||
If you're GitHub staff and need help with accessibility: | ||
- Visit the #accessibility Slack channel to ask questions or discuss accessibility issues | ||
- Check [github/accessibility](https://github.com/github/accessibility) repository for information on events or learning resources. | ||
- Attend the inclusive design office hours with @ichelsea on Tuesdays (the time alternates between 10am PST and 1pm PST every other week) | ||
|
||
## Support | ||
Accessibility is a priority for GitHub. If you ever encounter accessibility related issues when using github.com, please don’t hesitate to get in touch via [the contact page](https://support.github.com/contact) or email [support@github.com](support@github.com) with your concerns. | ||
|
||
For information about the accessibility compliance of GitHub products, please refer to the [VPAT report, outlining §508 accessibility information for GitHub.com, GitHub Enterprise, and GitHub Desktop](https://government.github.com/accessibility/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be written under the assumption that we are speaking to internal folks already? The last support section also feels more in line with what should be in our GitHub product support pages, not necessarily in our design docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if the purpose is in case a user lands on this page, and is looking for support?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if the purpose is in case a user lands on this page, and is looking for support?
Yep, I can envision anyone inside of GitHub that's curious about our accessibility efforts on the design team landing here.
Co-authored-by: Ash Guillaume <10384315+ashygee@users.noreply.github.com>
Co-authored-by: Ash Guillaume <10384315+ashygee@users.noreply.github.com>
Co-authored-by: Ash Guillaume <10384315+ashygee@users.noreply.github.com>
Co-authored-by: Ash Guillaume <10384315+ashygee@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Ready for feedback: