New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create accessibility menu page #227
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/design/Cn5A7PHqEgkfTvCB7b4EYVD7TATW |
Selecting "Accessibility" from the Interface guidelines menu page gives me a 404 and I can't figure out why 🤔
|
It gives a 404 because it's linking to the live site and that URL doesn't exist yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if you have any questions.
Co-authored-by: Inayaili León <yaili@github.com>
Co-authored-by: Inayaili León <yaili@github.com>
Co-authored-by: Inayaili León <yaili@github.com>
Co-authored-by: Inayaili León <yaili@github.com>
Co-authored-by: Inayaili León <yaili@github.com>
Co-authored-by: Inayaili León <yaili@github.com>
Co-authored-by: Inayaili León <yaili@github.com>
Co-authored-by: Inayaili León <yaili@github.com>
Co-authored-by: Inayaili León <yaili@github.com>
…ility-menu-page
Okay, @yaili! This one's ready for your eyes again 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were a few typos - can you put all the text through a spell checker to make sure nothing was missed? I'm not sure I caught everything.
Also, all the links are broken to the accessibility pages from the Accessibility overview page, so that needs to be fixed too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good (once @yaili's suggestions are done)
Co-authored-by: Inayaili León <yaili@github.com>
Selecting "Accessibility" on the side of the Interface guidelines page is the only section heading that doesn't have a menu. This PR adds in a menu and descriptions as well as rearranges the accessibility side nav links by type (generic or specific) and then by alphabetical order.
This PR adds a menu page for the Accessibility sections.