Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create accessibility menu page #227

Merged
merged 25 commits into from Mar 31, 2022
Merged

Create accessibility menu page #227

merged 25 commits into from Mar 31, 2022

Conversation

ichelsea
Copy link
Contributor

@ichelsea ichelsea commented Mar 9, 2022

Selecting "Accessibility" on the side of the Interface guidelines page is the only section heading that doesn't have a menu. This PR adds in a menu and descriptions as well as rearranges the accessibility side nav links by type (generic or specific) and then by alphabetical order.

""

This PR adds a menu page for the Accessibility sections.

@vercel
Copy link

vercel bot commented Mar 9, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/design/Cn5A7PHqEgkfTvCB7b4EYVD7TATW
✅ Preview: https://design-git-accessibility-menu-page-primer.vercel.app

@ichelsea
Copy link
Contributor Author

ichelsea commented Mar 9, 2022

Selecting "Accessibility" from the Interface guidelines menu page gives me a 404 and I can't figure out why 🤔

""
cc: @simurai

@yaili
Copy link
Member

yaili commented Mar 10, 2022

It gives a 404 because it's linking to the live site and that URL doesn't exist yet.

Copy link
Member

@yaili yaili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you have any questions.

content/accessibility/index.mdx Outdated Show resolved Hide resolved
content/accessibility/index.mdx Outdated Show resolved Hide resolved
content/accessibility/index.mdx Outdated Show resolved Hide resolved
content/accessibility/index.mdx Outdated Show resolved Hide resolved
content/accessibility/index.mdx Outdated Show resolved Hide resolved
content/accessibility/index.mdx Outdated Show resolved Hide resolved
content/accessibility/index.mdx Outdated Show resolved Hide resolved
content/accessibility/index.mdx Outdated Show resolved Hide resolved
content/accessibility/index.mdx Outdated Show resolved Hide resolved
content/accessibility/index.mdx Outdated Show resolved Hide resolved
Co-authored-by: Inayaili León <yaili@github.com>
ichelsea and others added 7 commits March 10, 2022 12:16
Co-authored-by: Inayaili León <yaili@github.com>
Co-authored-by: Inayaili León <yaili@github.com>
Co-authored-by: Inayaili León <yaili@github.com>
Co-authored-by: Inayaili León <yaili@github.com>
Co-authored-by: Inayaili León <yaili@github.com>
Co-authored-by: Inayaili León <yaili@github.com>
Co-authored-by: Inayaili León <yaili@github.com>
Co-authored-by: Inayaili León <yaili@github.com>
@ichelsea
Copy link
Contributor Author

Okay, @yaili! This one's ready for your eyes again 🙂

Copy link
Member

@yaili yaili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were a few typos - can you put all the text through a spell checker to make sure nothing was missed? I'm not sure I caught everything.

Also, all the links are broken to the accessibility pages from the Accessibility overview page, so that needs to be fixed too.

content/accessibility/index.mdx Outdated Show resolved Hide resolved
content/accessibility/index.mdx Outdated Show resolved Hide resolved
content/accessibility/index.mdx Outdated Show resolved Hide resolved
content/accessibility/index.mdx Outdated Show resolved Hide resolved
content/accessibility/index.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@bolonio bolonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good (once @yaili's suggestions are done)

Co-authored-by: Inayaili León <yaili@github.com>
@ichelsea ichelsea merged commit 219f99a into main Mar 31, 2022
@ichelsea ichelsea deleted the accessibility-menu-page branch March 31, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants