Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSR compatibility to component lifecycle criteria #440

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

colebemis
Copy link
Contributor

No description provided.

@colebemis colebemis requested a review from a team as a code owner March 17, 2023 21:26
@colebemis colebemis changed the title Add SSR compatibility to component lifecycle alpha criteria Add SSR compatibility to component lifecycle criteria Mar 17, 2023
Copy link
Member

@lesliecdubs lesliecdubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this change assuming we do fast-follow ups to address TreeView and ActionList which are already in Beta but don't meet the new SSR requirement.

More discussion for reference: https://github.slack.com/archives/C02NUUQ9C30/p1679088466733799

Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@colebemis colebemis merged commit eca234e into main Mar 23, 2023
@colebemis colebemis deleted the colebemis-patch-1 branch March 23, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants