Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update heading.js #706

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Update heading.js #706

merged 1 commit into from
Jan 30, 2024

Conversation

nsolerieu
Copy link
Contributor

Increase margin and padding of headings for a improved reading experience

See issue here: #699

Changes:

  • Margin top all heading to 1margin-top: 64px1 (previously 24px)
  • Margin bottom of all heading increase by one step 16 -> 24
  • Padding bottom of h1 and h2 adjusted to match margin bottom increase by one step 16 -> 24px

Previews:

H1 - H2
Screenshot 2023-11-29 at 12 14 22 PM

H3 - H4
Screenshot 2023-11-29 at 12 14 56 PM

Increase margin and padding of headings
@nsolerieu nsolerieu requested review from a team and joshblack November 29, 2023 20:20
Copy link

changeset-bot bot commented Nov 29, 2023

⚠️ No Changeset found

Latest commit: 1668601

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the implementation perspective! Also requested @mperrotti to review from a design perspective 👀

Copy link
Contributor

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 30, 2024
@nsolerieu nsolerieu merged commit c527e48 into main Jan 30, 2024
4 of 5 checks passed
@nsolerieu nsolerieu deleted the nsolerieu-spacing-patch-2 branch January 30, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants