Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hovered command palette item color is invisible with dark theme #14

Closed
kdrag0n opened this issue May 7, 2020 · 1 comment · Fixed by #37
Closed

Hovered command palette item color is invisible with dark theme #14

kdrag0n opened this issue May 7, 2020 · 1 comment · Fixed by #37
Labels
dark
Projects
🐞 GitHub theme issue tracking

Comments

@kdrag0n
Copy link

kdrag0n commented May 7, 2020

Normally, when hovering items in the command palette, there's a visible difference in the item's background color to differentiate it from the rest, but the highlight is invisible when using the dark theme.

Light (notice how the Toggle Developer Tools item is hovered):
image

Dark:
image
@simurai simurai added this to 📮 Inbox in 🐞 GitHub theme issue tracking via automation May 8, 2020
@simurai simurai moved this from 📮 Inbox to 🐎 High priority in 🐞 GitHub theme issue tracking May 8, 2020
@simurai simurai added the dark label May 8, 2020
@mazhengcn
Copy link

Anyone is working on this?

@simurai simurai mentioned this issue May 15, 2020
Merged
🐞 GitHub theme issue tracking automation moved this from 🐎 High priority to 💜 Done May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dark
Projects
🐞 GitHub theme issue tracking
  
💜 Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Increase contrast for list.hoverBackground primer/github-vscode-theme
3 participants
@simurai @mazhengcn @kdrag0n