Merge pull request #536 from jhawthorn/faster_octicon_cache

Make octicon helper slightly faster
primer · Feb 4, 2021 · 1be3275 · 1be3275
2 parents e0e204f + af7c6fc
commit 1be3275
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/octicons_gem/lib/octicons/octicon.rb b/lib/octicons_gem/lib/octicons/octicon.rb
@@ -11,7 +11,7 @@ def initialize(symbol, options = {})
         @width = octicon["width"]
         @height = octicon["height"]
         @keywords = octicon["keywords"]
-        @options = options
+        @options = options.dup
         @options.merge!({
           class:   classes,
           viewBox: viewbox,

diff --git a/lib/octicons_helper/lib/octicons_helper/helper.rb b/lib/octicons_helper/lib/octicons_helper/helper.rb
@@ -9,10 +9,10 @@ module OcticonsHelper
   def octicon(symbol, options = {})
     return "" if symbol.nil?
 
-    cache_key = [symbol, options].to_s
+    cache_key = [symbol, options]
 
-    if octicons_helper_cache[cache_key]
-      octicons_helper_cache[cache_key]
+    if tag = octicons_helper_cache[cache_key]
+      tag
     else
       icon = Octicons::Octicon.new(symbol, options)