Fill with color icon

[diegohdez90]

Provide user add fill color to icon.

[shawnbot]

Hi there! You can pass a fill attribute via the Ruby and Jekyll helpers, and a fill prop to the React component. Do you have a more specific question, or have you run into any issues passing fill to a specific library?

[diegohdez90]

I was trying add fill property in my Octicon React component with this:

<Octicon
  icon={GitPullRequest}
  fill='green'
/>

also with:

<Octicon
   icon={GitPullRequest}
   style={
   {
       fill: 'green'
   }}
/>

and none display me Octicon grren
What is the correct use of fill property?

Thanks

[shawnbot]

Hey, you're right! We're not passing along any additional props in the Octicon component. That's my bad. I'm labeling this as an issue and will get to it ASAP. Thank you for letting us know.

[diegohdez90]

There is an advance. ????

[shawnbot]

Not yet, no! Thanks for your patience, everyone. 🙇

[diegohdez90]

No problem. 🤓

[rutsky]

As a workaround you can set fill color from parent element:

<span style={{color: "red"}}><Octicon><Check /></Octicon></span>

[github-actions]

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.

[bodobraegger]

Hello! I think this issue still exists in current versions of primer. Any updates?