Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React: fill is not a style property, it's a svg attribute. #418

Closed
wants to merge 1 commit into from

Conversation

macno
Copy link

@macno macno commented Apr 29, 2020

Added a default to currentColor but it's possibile to overwrite it via 'fill' prop

Updates react test

It should fix also #240

@vercel
Copy link

vercel bot commented Apr 29, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/octicons/ldeaqst4x
✅ Preview: https://octicons-git-fork-macno-master.primer.now.sh

@vercel vercel bot temporarily deployed to Preview April 29, 2020 11:26 Inactive
@auareyou auareyou requested a review from colebemis April 29, 2020 11:47
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @macno! 🎉 This would be a great addition to the library. Could you update the docs to reflect this change? This is the markdown file for the react docs: https://github.com/primer/octicons/blob/master/docs/content/packages/react.mdx

Let me know if you have any questions :)

lib/octicons_react/src/index.js Outdated Show resolved Hide resolved
Added a default to currentColor but it's possibile to overwrite it via 'fill' prop

Updated react doc

Updates react test
@vercel vercel bot temporarily deployed to Preview April 30, 2020 04:55 Inactive
@macno
Copy link
Author

macno commented Apr 30, 2020

@colebemis no, thank you for the project :)

@macno
Copy link
Author

macno commented May 23, 2020

@colebemis Hi, I did all the changes suggested, do they look good to you?

@colebemis
Copy link
Contributor

@macno Sorry for the delay. We're working on releasing a new major version of Octicons that includes all the new icons you see on github.com. I'll probably bundle this change with that release.

@colebemis colebemis mentioned this pull request Feb 23, 2021
@colebemis
Copy link
Contributor

Closing in favor of #551

@colebemis colebemis closed this Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants