Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a keyboard shortcut to focus the search input #478

Closed
colebemis opened this issue Jul 21, 2020 · 1 comment
Closed

Create a keyboard shortcut to focus the search input #478

colebemis opened this issue Jul 21, 2020 · 1 comment

Comments

@colebemis
Copy link
Contributor

@brianlovin mentioned that searching for octicons is probably the first thing that people want to do when they go to https://primer.style/octicons. Let's add a keyboard shortcut (probably /) to focus the search input.

Notes

We currently have two search inputs on the https://primer.style/octicons page:

image

This is a problem we should fix in a separate issue. In this issue, let's focus on the search input that filters the grid of icons.

@edokoa edokoa linked a pull request May 27, 2021 that will close this issue
@edokoa edokoa removed a link to a pull request May 27, 2021
@github-actions
Copy link
Contributor

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant