Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon request] Unpin #940

Closed
yp05327 opened this issue Apr 10, 2023 · 5 comments
Closed

[Icon request] Unpin #940

yp05327 opened this issue Apr 10, 2023 · 5 comments
Assignees
Labels

Comments

@yp05327
Copy link

yp05327 commented Apr 10, 2023

Describe the topic

Could you add an unpin icon?

Anything else?

Thank you for this pretty icon set

@gavinmn
Copy link
Contributor

gavinmn commented Apr 11, 2023

Thanks for the request @yp05327 — I'll pass this along to the internal team!

@silverwind
Copy link

Current pin icon is

Screenshot 2023-04-17 at 17 08 01

My idea would a same icon, but with a strike-through, similar to these:

Screenshot 2023-04-17 at 17 08 27

@tallys tallys assigned tallys and CameronFoxly and unassigned tallys Apr 18, 2023
@CameronFoxly
Copy link
Contributor

CameronFoxly commented May 2, 2023

I've started thinking about adding this request to the library, and realized that we'll have to flip the direction of our pin icon, so that the slash follows the same directional conventions (slashing from top left to bottom right) of the rest of the library. This also actually seems like the right move for the pin icon because more of the icons in the library that have a diagonal composition tilt the way the the flipped version of the pin icon would (with the tip of the pin pointing left instead of right).

Here's my proposed solution for both an updated pin and the new unpin, at 2x and 1x in both 16px and 24px sizes:

Image

@tallys, can you check with product owners to make sure swapping the direction of the pin icon wouldn't be problematic?

@tallys
Copy link
Contributor

tallys commented May 9, 2023

Will follow up! Thanks @CameronFoxly

Ship it 🚀

@CameronFoxly
Copy link
Contributor

A new release went out this morning which has included the pin-slash icon. It can be seen here and is now included in the library and npm package. Thanks for the request, @yp05327.

Closing this out 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants