-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename some wrongly named icons #1023
base: main
Are you sure you want to change the base?
Conversation
We have other icons like `circle` and `circle-slash`. In Figma these icons are also called `circle-check`. It feels wrong to invert the naming logic for this one icon.
|
We have other icons like
circle
andcircle-slash
. In Figma these icons are also calledcircle-check
. It feels wrong to invert the naming logic for this one icon.The alternative would be to go the other way and rename the remaining icons and all figma icons to
[thing]-circle
.Warning
Warning: This is probably a breaking change. We could mitigate this by: