Creating a custom action for building all javascript based octicons packages #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
jonrohan
commented
Jan 31, 2019
| @@ -0,0 +1,3 @@ | |||
| #!/usr/bin/env node | |||
|
|
|||
| console.log("Create a build/data.json from the exported assets") | |||
There was a problem hiding this comment.
TODO: Right now the figma-action is specific to octicons and is still building the build/data.json for us. I'd like to make it more generic and do the conversion work here. Until then
emplums
reviewed
Jan 31, 2019
| @@ -17,9 +17,8 @@ | |||
| "url": "https://github.com/primer/octicons/issues" | |||
| }, | |||
| "scripts": { | |||
| "publish": "../../script/notify success", | |||
There was a problem hiding this comment.
Should we keep these in here until the publish stuff is merged in?
There was a problem hiding this comment.
Actions notifies for us now. 🥇
emplums
approved these changes
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a common action that builds any npm based project.
octicons_nodeandocticons_reactThe steps it does is
@shawnbot @emplums