v8.4.0 #281
v8.4.0 #281
Conversation
Co-Authored-By: jonrohan <rohan@github.com>
Co-Authored-By: jonrohan <rohan@github.com>
Creating a version action that versions the release based on PR logic
Using figma-action to export assest from the figma file
Converting Octicons workflow to a GitHub actions workflow
Co-Authored-By: jonrohan <rohan@github.com>
| @@ -30,5 +29,10 @@ | |||
| ], | |||
| "dependencies": { | |||
| "object-assign": "^4.1.1" | |||
There was a problem hiding this comment.
Not for now, but we should look into removing this dependency in favor of Object.assign(), since we're very likely not interested in supporting browsers that don't have it anymore.
| @@ -45,7 +41,6 @@ | |||
| "fs-extra": "^6.0.1", | |||
| "jest": "^23.2.0", | |||
| "next": "^5.1.0", | |||
| "octicons": "8.3.0", | |||
| "primer-react": "0.0.6-alpha.1", | |||
There was a problem hiding this comment.
never have dependencies, that's what I say
There was a problem hiding this comment.
This is epic, @jonrohan. I left a couple of notes, but they're not blockers by any stretch.
The only thing I'm not 100% sure of is whether this changes whether/where the JSON data files live in the published npm packages. If there's any possibility of "breaking" that API, we might want to make this a major version bump. Otherwise, 🚀
For now it's the same, generated by the figma action, however I would like to have the figma action be more generic and then build the data.json based on output from it |
Release v8.4.0
🏠 Internal
Release Steps
npm version 8.4.0on this branch