Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scoping npm packages to organization @primer/octicons and @primer/octicons-react #311

Merged
merged 2 commits into from
May 23, 2019

Conversation

jonrohan
Copy link
Member

This updates both the npm octicons package and the npm octicons-react package to live under the @primer org name.

@shawnbot

@jonrohan jonrohan requested a review from shawnbot May 23, 2019 19:21
@jonrohan jonrohan added this to Work In Progress in Octicons release tracking via automation May 23, 2019
@emplums
Copy link
Contributor

emplums commented May 23, 2019

Are there any other documentation places like primer.style that should be updated too?

@jonrohan
Copy link
Member Author

Are there any other documentation places like primer.style that should be updated too?

From what I can tell, everything else is import related https://github.com/search?q=org%3Aprimer+%22githubprimer%2F%22&type=Code

@shawnbot shawnbot mentioned this pull request May 23, 2019
4 tasks
@jonrohan jonrohan changed the base branch from master to release-9.0.0 May 23, 2019 20:17
@jonrohan jonrohan merged commit 624c8e1 into release-9.0.0 May 23, 2019
Octicons release tracking automation moved this from Work In Progress to 💜 Done May 23, 2019
@jonrohan jonrohan deleted the rename-packages branch May 23, 2019 20:36
outofambit added a commit to desktop/desktop that referenced this pull request Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants