Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for duplicate icon names and fail when two icons have the same name #322

Merged
merged 9 commits into from
Jun 21, 2019
Merged

Test for duplicate icon names and fail when two icons have the same name #322

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f37f012
output json
jonrohan Jun 20, 2019
266a967
Add test to search for duplicate icons
jonrohan Jun 20, 2019
89e03c8
Using for of
jonrohan Jun 20, 2019
4e24fd3
test data exists
jonrohan Jun 20, 2019
f0eda96
test with bad file
jonrohan Jun 20, 2019
524b93d
Test each icon separately
jonrohan Jun 20, 2019
2434ee8
Verbose output
jonrohan Jun 20, 2019
aa7cc5a
Back to main file
jonrohan Jun 20, 2019
e82056f
Updating test on feedback
jonrohan Jun 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "9.1.0",
"scripts": {
"version": "script/version",
"test": "ava tests/*.js",
"test": "ava -v tests/*.js",
"lint": "eslint tests"
},
"dependencies": {
Expand Down
17 changes: 17 additions & 0 deletions tests/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ const globby = require('globby')
const year = new Date().getFullYear()
const yearRegex = new RegExp(`Copyright \\(c\\) ${year} GitHub Inc\\.`)
const octiconsLib = fs.readdirSync('./lib/build/svg')
const octiconsData = require('../lib/build/data.json')

test(`LICENSE files have the current year ${year}`, t => {
return globby(['**/LICENSE', '!**/node_modules/**/LICENSE', '!**/vendor/**/LICENSE']).then(paths => {
Expand All @@ -19,3 +20,19 @@ test(`LICENSE files have the current year ${year}`, t => {
test('SVG icons exist', t => {
t.not(octiconsLib.length, 0, `We didn't find any svg files`)
})

test('Data file exist', t => {
t.not(octiconsData.length, 0, `We didn't find any data files`)
})

const names = {}
for (const o of Object.values(octiconsData)) {
jonrohan marked this conversation as resolved.
Show resolved Hide resolved
test(`No duplicate ${o.name} icon`, t => {
if (names[o.name]) {
t.fail(`Found duplicate '${o.name}' icons in the figma file. Please rename one of them.`)
jonrohan marked this conversation as resolved.
Show resolved Hide resolved
} else {
names[o.name] = o
t.pass()
}
})
}