Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[React] Allow 'unset' value for verticalAlign property #354

Merged
merged 1 commit into from Nov 1, 2019

Conversation

@Fs00
Copy link
Contributor

Fs00 commented Oct 17, 2019

This PR adjusts type-checking of the React Octicon component to allow users to set the verticalAlign property to unset.
I'm currently using Octicons for a project of mine and without this change I can't perfectly center an octicon vertically inside a flex container, since vertical-align CSS property on the icon clashes with flex align-items.

@emplums emplums requested a review from shawnbot Oct 22, 2019
@Fs00 Fs00 mentioned this pull request Oct 31, 2019
4 of 6 tasks complete
@jonrohan jonrohan changed the base branch from master to release-9.3.0 Nov 1, 2019
@jonrohan

This comment has been minimized.

Copy link
Member

jonrohan commented Nov 1, 2019

Thanks for the contribution @Fs00 I'm going to add it to 9.3.0

@jonrohan jonrohan merged commit 10c530b into primer:release-9.3.0 Nov 1, 2019
@Fs00

This comment has been minimized.

Copy link
Contributor Author

Fs00 commented Nov 1, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.