Fix Safari rendering of arrows #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/octicons/ejulpsdqw |
|
👋 |
colebemis
approved these changes
Feb 2, 2021
|
Thank you, @aaronshekey ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #485 by removing fill-rules from the problematic arrow icons. This can be seen on 1x screens running Safari. It's also visible in quickview on macOS.
I also re-authored the
desktop-download-16to assume a non-zero fill rule, which Safari expects. Seems other browsers do not have this assumption. I think the root cause is these icons were authored with non-zero fills, but then the SVG toggles them to beevenodd. Safari seems to be the only browser that cares about this discrepancy.