Multi select #534
Merged
Multi select #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/octicons/qvaikn7ey |
|
Thanks for opening this PR, @Juliusschaeper! The different spacing in spacing between the caret and the dot looks a little off to me in the 24px version. I'm curious to see what it would look like if the spacing was equal.
|
|
@colebemis Good catch, thanks! I increased the spacing to 2.5px between stroke and chevron. 3px felt a bit too much because of the angled shape of the chevron. |
colebemis
approved these changes
Feb 4, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 16 + 24px multi select icons.