Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save table-24.svg, table-16.svg #564

Merged
merged 6 commits into from
Apr 2, 2021
Merged

Save table-24.svg, table-16.svg #564

merged 6 commits into from
Apr 2, 2021

Conversation

ashygee
Copy link
Contributor

@ashygee ashygee commented Mar 23, 2021

This PR adds a table icon to Octicons

image

@vercel
Copy link

vercel bot commented Mar 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/octicons/DT3tWhFe2JsBmo8e8CWbXcqMv4Jp
✅ Preview: https://octicons-git-add-table-primer.vercel.app

@vercel vercel bot temporarily deployed to Preview March 23, 2021 20:04 Inactive
@vercel vercel bot temporarily deployed to Preview March 23, 2021 22:21 Inactive
@vercel vercel bot temporarily deployed to Preview March 23, 2021 22:24 Inactive
@colebemis
Copy link
Contributor

colebemis commented Mar 24, 2021

These look great, @ashygee!

The header and sidebar in the 16px version don't look quite proportional with the 24px version. What if we made them a little skinnier:

image

https://www.figma.com/file/2rjsQp42uKvzPXzLZIqOeA/Octicons-v2---Source?node-id=5855%3A15410

@ashygee
Copy link
Contributor Author

ashygee commented Mar 24, 2021

@colebemis that looks good to me! Let's push that change up.

@vercel vercel bot temporarily deployed to Preview March 24, 2021 21:42 Inactive
@vercel vercel bot temporarily deployed to Preview March 24, 2021 21:45 Inactive
@ashygee ashygee mentioned this pull request Apr 1, 2021
14 tasks
@ashygee ashygee changed the base branch from master to release-13.0.0 April 2, 2021 19:39
@ashygee ashygee merged commit a4f31b5 into release-13.0.0 Apr 2, 2021
@ashygee ashygee deleted the add-table branch April 2, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants