Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number icon #592

Merged
merged 10 commits into from
May 13, 2021
Merged

Number icon #592

merged 10 commits into from
May 13, 2021

Conversation

Juliusschaeper
Copy link
Contributor

@Juliusschaeper Juliusschaeper commented Apr 12, 2021 •
edited by ashygee
Loading

This PR modifies the current number icon with the new SVG and renames the old SVG to hash.

@vercel
Copy link

vercel bot commented Apr 12, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/octicons/5ca3ora28NMYHMekc9rDKeokJXRN
✅ Preview: https://octicons-git-number-icon-primer.vercel.app

@vercel vercel bot temporarily deployed to Preview April 12, 2021 15:29 Inactive
@colebemis
Copy link
Contributor

Nice work, @Juliusschaeper! The icons look good.

It looks like this PR replaces the old # icon which I don't think is what we want. We should decide what we want to call the # icon now or if we want to rename this icon.

@vercel vercel bot temporarily deployed to Preview April 13, 2021 16:22 Inactive
@vercel vercel bot temporarily deployed to Preview April 13, 2021 16:26 Inactive
@ashygee
Copy link
Contributor

ashygee commented Apr 14, 2021

@Juliusschaeper we need to replace the current number-24 with the new hash-24 name too.

@vercel vercel bot temporarily deployed to Preview April 14, 2021 17:04 Inactive
@vercel vercel bot temporarily deployed to Preview April 14, 2021 17:08 Inactive
@ashygee ashygee self-requested a review April 14, 2021 17:31
ashygee
ashygee approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@ashygee ashygee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍🏼

@colebemis
Copy link
Contributor

number icon looks great 👍

The top-left and bottom-right steps on the hash icon look a little long to me though:
CleanShot 2021-05-12 at 09 25 58

@vercel vercel bot temporarily deployed to Preview May 12, 2021 19:54 Inactive
@ashygee ashygee changed the base branch from main to release-14.0.0 May 13, 2021 21:00
@ashygee ashygee merged commit 437947f into release-14.0.0 May 13, 2021
@ashygee ashygee deleted the number-icon branch May 13, 2021 21:01
@ashygee ashygee mentioned this pull request May 13, 2021
Merged
13 tasks
@renovate renovate bot mentioned this pull request May 22, 2021
Merged
1 task
This was referenced Aug 2, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashygee ashygee ashygee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Juliusschaeper @colebemis @ashygee @actions-user