Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds filled bell icon at 16px size #657

Merged
merged 1 commit into from
Aug 24, 2021
Merged

Conversation

mperrotti
Copy link
Contributor

Adds the icon requested in Primer issue https://github.com/github/primer/issues/260

I've also added this icon to Octicons v2 in Figma

@mperrotti
Copy link
Contributor Author

I haven't created a release branch yet because I'm not sure how we do versioning in this repo.

If we go by semantic versioning, I'd assume the release for this icon should be 15.1.0 because it's adding a new "feature" (icon). If this assumption is incorrect, please explain how I should increment versions in this repo.

Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, @mperrotti! Your assumption about versioning is correct. We treat new icons as minor releases. The next version should be 15.1.0

@mperrotti mperrotti changed the base branch from main to release-15.1.0 August 24, 2021 13:56
@mperrotti mperrotti merged commit 1bc85cc into release-15.1.0 Aug 24, 2021
@mperrotti mperrotti deleted the mp/bell-16-filled branch August 24, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants