Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update contribution guidelines #734

Merged
merged 4 commits into from
Feb 8, 2022
Merged

update contribution guidelines #734

merged 4 commits into from
Feb 8, 2022

Conversation

ashygee
Copy link
Contributor

@ashygee ashygee commented Jan 28, 2022

This PR adds a note for where to commit a changeset.

@ashygee ashygee self-assigned this Jan 28, 2022
@ashygee ashygee requested a review from a team as a code owner January 28, 2022 15:59
@ashygee ashygee requested a review from edokoa January 28, 2022 15:59
@changeset-bot
Copy link

changeset-bot bot commented Jan 28, 2022

⚠️ No Changeset found

Latest commit: 4be66b6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Base automatically changed from upload-24px-correction to main January 28, 2022 17:47
Juliusschaeper
Juliusschaeper approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@Juliusschaeper Juliusschaeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ashygee ashygee merged commit afde0dd into main Feb 8, 2022
@ashygee ashygee deleted the contribution-update branch February 8, 2022 16:55
@primer-css primer-css mentioned this pull request Feb 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Juliusschaeper Juliusschaeper Juliusschaeper approved these changes

@edokoa edokoa Awaiting requested review from edokoa edokoa is a code owner automatically assigned from primer/octicons-reviewers

@colebemis colebemis Awaiting requested review from colebemis

Assignees

@ashygee ashygee

Labels
skip-changeset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ashygee @Juliusschaeper @edokoa @actions-user