Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save file-directory-32.svg, file-directory-fill-32.svg #736

Merged
merged 10 commits into from
Feb 15, 2022

Conversation

edokoa
Copy link
Contributor

@edokoa edokoa commented Feb 2, 2022

Updated file-directory icons to fix naming problem and add non-filled icon.

This PR is linked to https://github.com/github/primer/issues/638

@edokoa edokoa requested a review from a team as a code owner February 2, 2022 15:03
@edokoa edokoa requested a review from colebemis February 2, 2022 15:03
@changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2022

🦋 Changeset detected

Latest commit: bbaa1ba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/octicons Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@ashygee ashygee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you're uploading the 2x version of the 16px icon because they're appended with -32

@edokoa
Copy link
Contributor Author

edokoa commented Feb 3, 2022

@ashygee my bad. It's a classic. I fixed it.

@edokoa edokoa requested a review from ashygee February 3, 2022 08:12
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Copy link
Contributor

@ashygee ashygee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@edokoa edokoa deleted the file-directory_fixes branch February 15, 2022 17:52
@primer-css primer-css mentioned this pull request Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants