Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update rollup config #854

Merged
merged 2 commits into from
Oct 13, 2022
Merged

chore: update rollup config #854

merged 2 commits into from
Oct 13, 2022

Conversation

joshblack
Copy link
Member

The @primer/styled-octicons step in the react job is currently failing: https://github.com/primer/octicons/actions/runs/3208168870/jobs/5243790946

This PR updates the rollup config for lib/styled_octicons to resolve presets relative to the package instead of the files. This should address the error where the babel rollup plugin is unable to find the presets/plugins that it's looking for.

@joshblack joshblack requested a review from a team as a code owner October 13, 2022 16:28
@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2022

⚠️ No Changeset found

Latest commit: 1bfd7f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants