-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save passkey-fill-24.svg, passkey-fill-16.svg #927
Conversation
🦋 Changeset detectedLatest commit: e2b94c4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Should this be called |
🤔 That's a good question. It's technically a filled icon, but it's not a filled icon with an outline icon counterpart since it's made specifically to follow the passkey spec. @tallys any opinions since this is kind of half a branded icon? |
We don't do different colors or modifications for Octicons in dark mode as far as I know, but once these are merged and released to the library they should be able to be used the same way you're currently using Octicons. Does that work or do you need to use the SVGs earlier? |
@gavinmn and @colebemis let's stick to our naming conventions and give it 'fill' title for consistency, even though there's not a counterpart. This is a bit of an edge case, but I think consistency in the library makes more sense |
Ah thanks, I didn't know this. In that case this should be fine, thank you so much! |
Closes https://github.com/github/primer/issues/1672
Adds the Passkey icons