Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README Image concepts #90

Closed
ashygee opened this issue Nov 21, 2018 · 4 comments
Closed

README Image concepts #90

ashygee opened this issue Nov 21, 2018 · 4 comments
Assignees
Labels
status: wip work in progress

Comments

@ashygee
Copy link
Contributor

ashygee commented Nov 21, 2018

Per the conversation with @broccolini on Primer illustrations, I've updated the readme concepts for the primer/styles and primer/components readme's.

screenshot 2018-11-20 16 15 32

You can view in detail in the figma file. I've also included some mocks of what the readme will look like when viewed on GitHub. View in Figma

@ashygee ashygee added the status: wip work in progress label Nov 21, 2018
@ashygee
Copy link
Contributor Author

ashygee commented Nov 21, 2018

screenshot 2018-11-21 12 05 03

Trying to get closer to the website illustration styles. I took some of the inspiration from this image:
screenshot 2018-11-21 12 05 28

  • Reverted the Octicon's to their original positioning
  • Playing with the stroke widths. I'm now using the same stroke widths of .75pt and 2pt as seen in the website illustration files
  • Removed overlapping of outlined geometric shapes

@broccolini
Copy link
Member

broccolini commented Nov 21, 2018

Thanks @ashygee this is heading in the right direction! Some feedback below (also posted in slack earlier):

  • The far left options look best to me, though I'd be interested in seeing an option with light blue dots outside the box similar to how they do it on the site pages.
  • I think these should be a test case for the updated/consolidated styles so I'd like to see the single color thin lines vs thicker stroke lighter blue lines (like the site illos)
  • The hand-drawn style line connects the octicons in other illustrations we have, so the line appears to come out of the end of the icon, on these ones it seems to be connecting the boxes instead which doesn't feel right to me - let me know if there is a reason for this though
  • Outline shapes like the hexagon and the circle shouldn't overlap. From what I've seen on the site designs they do not overlap. We shouldn't do that either. (I noticed we do on the team page illo so we should fix that.)
  • The lightning bolt icon rotated looks odd. I don't think any octicons should be rotated.
  • The top right option has a the top line of code blocks very close to the edge, when we use the code blocks I think they should obviously overlap the edge of a shape or have a good amount of space.

@ashygee
Copy link
Contributor Author

ashygee commented Nov 27, 2018

@broccolini I've gone ahead and fine-tuned the concepts with your feedback. The concepts for primer/styles and primer/components both have three different variations for background:

  • A: Outline Box
  • B: Dot Pattern
  • C: Outline Box + Dot Pattern

primer/styles concepts

screenshot 2018-11-27 15 07 36

primer/components concepts

screenshot 2018-11-27 14 56 56

Details

  • For Style A I wanted to focus on the simplicity of Primer's style. For both /style and /components I've used the primitive shapes seen in the original primer banners.
  • The dot pattern for B & C has been lightened to blue-100 in order to better suit the white background of the readme on github.com and npm.
  • The dot pattern on C is thinner to take into account of the outline box pairing.
  • Stroke width variation is now similar to the web illustrations. 1px stroke is used for all connecting lines. The thicker stroke is consistent at 2px.
  • 3px stroke for the squiggle paired with the paintbrush and the outline on style B.
  • For the /components concepts the hand-drawn line connects the octicons as seen in the other illustrations instead of the blocks.
  • Octicons have been rotated/flipped back to their correct and original positioning.
  • Each overlapping element maintains consistent spacing with our spacing guidelines by being on a base 8.
    screenshot 2018-11-27 14 54 00

Mocks

Example screen mocks of the README images can be seen in full resolution in Figma.

screenshot 2018-11-27 15 12 55
screenshot 2018-11-27 15 13 07

@ashygee
Copy link
Contributor Author

ashygee commented Dec 6, 2018

screenshot 2018-12-03 14 09 55

README images live on primer/components and primer/primer.style repos

@ashygee ashygee closed this as completed Dec 6, 2018
@ashygee ashygee mentioned this issue Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: wip work in progress
Projects
None yet
Development

No branches or pull requests

2 participants