Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primer Brand and Illustration Guidelines #91

Closed
14 of 26 tasks
ashygee opened this issue Nov 21, 2018 · 9 comments
Closed
14 of 26 tasks

Primer Brand and Illustration Guidelines #91

ashygee opened this issue Nov 21, 2018 · 9 comments

Comments

@ashygee
Copy link
Contributor

ashygee commented Nov 21, 2018

What & why

As we continue to expand the Primer brand with new sites and updates, we are running into more use cases where consistent illustrations are needed to correctly represent the Primer brand.

Known issues/things to consider

  • Currently the public interprets the Primer logo to be the package Octicon, but this has not bet solidified
  • Pairing illustrations to be consistent with the site illustrations but also maintaining Primer as a separate entity
  • There is currently no illustration-specific documentation
  • The illustrations should be consistent proportionally as they will need to scale based on use and display size

Who

  • @ashygee will create documentation and set up a component system for the illustrations
  • @broccolini to provide current guidelines and support with design feedback and reviews (@emilybrick to support with this as well?)

Tracking

The following assets are needed or need to be updated with new style:

Primer.style

  • Homepage
    • Update Hero illustration
    • Update Octicons illustration
  • Update Team page illustration
  • Update News illustration

Sub-site hero images

  • Primer CSS
  • Update Primer Design
  • Update Primer Components

Readme Images

  • Update Primer.style
  • Primer Design
  • Primer Components
  • Primer CSS

Social Images

  • Spectrum chat background
  • Spectrum chat avatar
  • Twitter background
  • Twitter avatar
  • Facebook
  • OG images
    • Primer.style
    • Design
    • CSS
    • Components
  • Template for marketing social media images

Identity

  • Global Favicon (currently package icon on or GitHub mark, or none at all)
  • Repo avatar (should be consistent with Twitter Avatar etc.
  • Bot avatar (can have a simple differentiator like a different color)

Related Issues and Discussions

@ashygee ashygee transferred this issue from primer/css Nov 26, 2018
@ashygee ashygee added this to To Do in primer.style tracking Dec 3, 2018
@ashygee ashygee moved this from To Do to In progress in primer.style tracking Dec 3, 2018
@ashygee ashygee moved this from In progress to Backlog in primer.style tracking Jan 14, 2019
@ashygee
Copy link
Contributor Author

ashygee commented Feb 21, 2019

Template for social images started in Figma.

Because Figma has pre-set frame sizes for various social media platforms I think we can just add to this file. I'll set up some more social images that we can drop into our posts in the future.

@ashygee ashygee moved this from Backlog to In progress in primer.style tracking Feb 25, 2019
@ashygee
Copy link
Contributor Author

ashygee commented Mar 1, 2019

Homepage Illustration Update

Original
site original

Option 1
site option 1

Option 2
site option 2

Option 3
site option 3

Octiocons Illustration Update

Original
site octicons original

Update
site octicons

CC @broccolini @emilybrick

@ashygee
Copy link
Contributor Author

ashygee commented Mar 2, 2019

Favicon updates are tied to #114.

@broccolini
Copy link
Member

Thanks for working on this @ashygee! I think I need to see the header illustration in context with the rest of the page, it's hard for me to tell what works best when it's cropped tightly since that's not how we see it in the browser—if you have this setup with the full page in Figma can you share the link, or we can jump on a call and look through it.

Octicons is almost there but I think has a few too many details that are distracting against the surrounding content, though it looks slightly closer to the content below. I think it's also due to the higher contrast of some of the elements. Perhaps we can look at this in the browser or Figma together too?

@ashygee
Copy link
Contributor Author

ashygee commented Mar 2, 2019

Thanks for the feedback @broccolini!

I don't have a mock with the rest of the page yet but that's something I can set up for further discussion. I'll share the link here once I have it up.

For the Octicons illustration I will remove some of the outside details and see how that feels.

@ashygee
Copy link
Contributor Author

ashygee commented Mar 5, 2019

@broccolini I've set up a Figma file with some site mocks to view the illustrations within the full page. I also went ahead and removed some of the outer decorative elements on the Octicons illustration. Looking forward to discussing with you! 😄

@ashygee
Copy link
Contributor Author

ashygee commented Mar 12, 2019

@broccolini Avatar ideas up on Figma. There are two versions of the paintbrush taken from the previous favicon exploration in #114.

Avatar-paintbrush Avatar-inverted

@broccolini
Copy link
Member

I'm inclined to go with the first one (dark background, more detail) and see how it works in practice. I'm fully okay with being wrong and it not working, but I think best way to test this type of change is to ship it :)

@ashygee
Copy link
Contributor Author

ashygee commented Mar 25, 2019

@broccolini Great! I'll export and we can replace and test

@yaili yaili moved this from In progress to To do in primer.style tracking Feb 25, 2020
@yaili yaili closed this as completed Mar 18, 2020
primer.style tracking automation moved this from To do to Done Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

3 participants