uploaded new favicon files #118
Conversation
| "now": "11.4.6", | ||
| "now-github-url": "0.1.2", | ||
| "serve": "10.0.0" | ||
| "serve": "10.1.2" |
There was a problem hiding this comment.
serve kept complaining so I updated. 🤷♂️
| @@ -0,0 +1,29 @@ | |||
| /* eslint-disable github/unescaped-html-literal */ | |||
There was a problem hiding this comment.
Our eslint rules don't like unescaped HTML literals, which is definitely good. It's not currently possible to inject unsafe markup into these elements (via process.argv or elsewhere), though, so I think disabling this here is okay.
src/icons/index.js
Outdated
| const meta = ({name, file}) => `<link name="${name}" content="${path(file)}">` | ||
|
|
||
| module.exports = [ | ||
| link({rel: 'icon', type: 'image/png', file: 'favicon.png'}), |
There was a problem hiding this comment.
@ashygee this is currently how we create icon links and meta tags. The link() and meta() functions take an object of HTML attributes, with one exception: file is a filename relative to src/icons, which gets copied at build time (no hot module reloading for now) and prefixed with the path to the file on the server.
So in this case, file: 'favicon.png' causes src/icons/favicon.png to be copied to the output directory (build/icons/favicon.png), and the <link> tag gets href="/icons/favicon.png".
| gtag('config', 'UA-126681523-1'); | ||
| </script> | ||
|
|
||
| <link rel='stylesheet' href='https://unpkg.com/@primer/css/dist/layout.css' /> |
There was a problem hiding this comment.
FYI, this is the new unpkg URL for the layout bundle in @primer/css>=12.
|
@emplums can I get a gut check on this approach? x0 doesn't bundle the HTML template, so we can't use loaders or plugins to change the static HTML output, which is when we need to inject the octicons. This is a pretty janky way of doing it, but it gets @ashygee unblocked, so I'm inclined to roll with it until we decide to rebuild this site with Blueprints. |
Co-Authored-By: ashygee <10384315+ashygee@users.noreply.github.com>
|
This closes #114 |
|
@emplums Hmm that's weird, because it should be completely static. And it looks like it is if you visit <!DOCTYPE html><head><title>Primer open-source projects</title><meta charset="utf-8"><meta name="viewport" content="width=device-width,initial-scale=1"><link rel="icon" type="image/png" href="/icons/favicon-32.png"><link rel="icon" type="image/png" href="/icons/favicon-48.png"><link rel="icon" type="image/png" href="/icons/favicon-96.png"><link rel="icon" type="image/png" href="/icons/favicon-144.png"><link rel="icon" type="image/png" href="/icons/favicon-192.png"><link rel="apple-touch-icon" type="image/png" href="/icons/touch-icon-iphone.png"><link rel="apple-touch-icon" type="image/png" href="/icons/touch-icon-ipad.png"><link rel="apple-touch-icon" type="image/png" href="/icons/touch-icon-ipad-retina.png"><link rel="apple-touch-icon" type="image/png" href="/icons/touch-icon-iphone-retina.png"><link rel="icon" type="image/png" href="/icons/android-icon.png"><link name="msapplication-square310x310logo" content="/icons/microsoft-icon.png">So maybe it's just your cache warming up and not an SSR/hydration issue? |
uploaded new favicon files
updating the favicon and touch-icons.